Skip to content

Commit

Permalink
Fix snapshot flake
Browse files Browse the repository at this point in the history
Avoid "snapshot save already in progress" flake when snapshot reconcile from previous save is still in progress.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 68fbd1a)
Signed-off-by: Brad Davidson <[email protected]>
  • Loading branch information
brandond committed Jan 10, 2025
1 parent e626300 commit 3e2ef58
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/e2e/s3/s3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,10 @@ var _ = Describe("Verify Create", Ordered, func() {
It("prunes s3 snapshots", func() {
_, err := e2e.RunCmdOnNode("k3s etcd-snapshot save", serverNodeNames[0])
Expect(err).NotTo(HaveOccurred())
time.Sleep(time.Second)
_, err = e2e.RunCmdOnNode("k3s etcd-snapshot save", serverNodeNames[0])
Expect(err).NotTo(HaveOccurred())
time.Sleep(time.Second)
res, err := e2e.RunCmdOnNode("k3s etcd-snapshot prune", serverNodeNames[0])
Expect(err).NotTo(HaveOccurred())
// There should now be 4 on-demand snapshots - 2 local, and 2 on s3
Expand Down

0 comments on commit 3e2ef58

Please sign in to comment.