bulletproofs: update to criterion 0.5 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criterion is already a dev-dependency. It's not necessary to include it was a direct dependency as well.
Port to the latest release of the criterion benchmark framework. The `benchmark_function_with_inputs` API has been deprecated since v0.3 and is removed in v0.4 and v0.5 so benchmarks are ported to the new `BenchmarkGroup::bench_with_input` method. Addresses `cargo audit` warnings about transitive dependencies.
|
In local testing I saw one 1% slowdown, all other tests were ~5% speed ups. These were informal runs though, so those changes are within the noise floor. |
|
super awesome @rillian ! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to the latest release of the criterion benchmark framework.
The
benchmark_function_with_inputsAPI has been deprecated since v0.3 and is removed in v0.4 and v0.5 so benchmarks are ported to the newBenchmarkGroup::bench_with_inputmethod.Addresses
cargo auditwarnings about transitive dependencies.This follows as similar upstream patch dalek-cryptography/bulletproofs#375