-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notification permission for sync #27276
Open
deeppandya
wants to merge
2
commits into
master
Choose a base branch
from
add_notification_permission_for_sync
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
CI/skip-windows-x64
Do not run CI builds for Windows x64
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
labels
Jan 17, 2025
samartnik
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
deeppandya
force-pushed
the
add_notification_permission_for_sync
branch
from
January 22, 2025 19:56
3605cb6
to
e140c03
Compare
* the terms of the Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed with | ||
* this file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
*/ | ||
>>>>>>> 6060cc31b46 (Add notification permission function in Utils) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a conflict needs to be resolved
android/java/org/chromium/chrome/browser/settings/BraveSyncScreensPreference.java
Show resolved
Hide resolved
Add notification permission for sync
Resolve rebase conflict
deeppandya
force-pushed
the
add_notification_permission_for_sync
branch
from
January 23, 2025 20:29
e140c03
to
1a85c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/skip-ios
Do not run CI builds for iOS
CI/skip-macos-arm64
Do not run CI builds for macOS arm64
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-windows-x64
Do not run CI builds for Windows x64
unused-CI/skip-linux-x64
Do not run CI builds for Linux x64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42440
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: