Add logic to output ofac-sanctioned-digital-currency-addresses.json #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We don't know which chain IDs or coinTypes will be added by OFAC upstream, and it's difficult given an arbitrary symbol to identify which chain ID / CoinType it is. So it's easier to just put all the banned addresses in a flat namespace. There's only 540 so it's not really a performance hit to check all of them for an Ethereum transaction instead of just the ETH ones.
GITHUB_TOKEN -> API_AUTH_TOKEN_GITHUB The IT asked for a more descriptive name. Also, apparently you variables cannot start with the prefix 'GITHUB'.
|
Merging even though the build failed since the build failed due to a missing GITHUB_API_AUTH_TOKEN. That secret is set, I just think it's only exposed from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates a new file
ofac-sanctioned-digital-currency-addresses.json, that looks like this:It's just a flat list of addresses to not send transfers to, and includes every coin type (e.g. bitcoin, EVM, and Solana addresses are all included in the one array).
The list is generated by parsing the
listsbranch of this repo https://github.com/brave-intl/ofac-sanctioned-digital-currency-addresses/tree/lists. That repo has a daily job that scrapes the digital currency addresses from the OFAC website, and outputs them insanctioned_addresses_*.jsonfiles at the top level of the github repo.In order to fetch those files from our github repo, the code in this change uses the github API, which requires an authentication token
GITHUB_TOKEN, which must be added as an environment variable to this repo.That list is parsed clientside and checked prior to regular transfers and token transfers in brave-core in this pull request.
Security review - https://github.com/brave/reviews/issues/1273.