Skip to content

Commit

Permalink
Increase timeouts for e2e Packets tests (#2978)
Browse files Browse the repository at this point in the history
  • Loading branch information
philrz authored Jan 19, 2024
1 parent 123f1cc commit e275ddd
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ on:
- 'true'
- 'false'
required: true
debug:
description: Playwright debug logging
type: choice
options:
- 'pw:api'
- ''
always-upload:
description: Always upload artifacts even if tests don't fail?
type: boolean
Expand Down Expand Up @@ -56,6 +62,7 @@ jobs:
fi
env:
VIDEO: ${{ inputs.video }}
DEBUG: ${{ inputs.debug }}
shell: sh
- name: Put system logs alongside other artifacts
run: |
Expand Down
11 changes: 11 additions & 0 deletions packages/zui-player/tests/packets.spec.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
import { play } from 'zui-player';
import { getPath } from 'zui-test-data';
import { isCI } from '../helpers/env';

// Timeouts are increased due to observed long pcap load times in CI.
// See https://github.com/brimdata/zui/pull/2978
play('packets.spec', (app, test) => {
test('dropping a pcap does not pop up preview and load', async () => {
if (isCI()) {
test.setTimeout(120000);
app.page.setDefaultTimeout(120000);
}
await app.dropFile(getPath('sample.pcap'));
await app.attached(/Successfully loaded into sample.pcap/);
});
Expand All @@ -17,6 +24,10 @@ play('packets.spec', (app, test) => {
});

test('loading a bad pcap displays an error message', async () => {
if (isCI()) {
test.setTimeout(120000);
app.page.setDefaultTimeout(120000);
}
await app.dropFile(getPath('bad.pcapng'));
await app.attached(/Unable to generate full summary logs from PCAP/);
});
Expand Down

0 comments on commit e275ddd

Please sign in to comment.