Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zui Insiders dev builds #2863

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix Zui Insiders dev builds #2863

merged 3 commits into from
Oct 24, 2023

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Oct 24, 2023

I tried to use this workflow for the first time in a while and it failed (https://github.com/brimdata/zui/actions/runs/6630692331). I dug into the history a bit and it looks like some changes to the regular Insiders Release workflow in #2833 and #2818 didn't make their way into this workflow. I've made what I think are the necessary changes to get it running again and have successfully built/installed/used an artifact based on this branch (https://github.com/brimdata/zui/actions/runs/6632098539).

@philrz philrz requested a review from jameskerr October 24, 2023 20:43
@philrz philrz self-assigned this Oct 24, 2023
@philrz philrz changed the title Fix Zui Insiders nsiders dev builds Fix Zui Insiders dev builds Oct 24, 2023
Copy link
Member

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@philrz philrz merged commit 1de67ce into main Oct 24, 2023
7 checks passed
@philrz philrz deleted the fix-insiders-dev-build branch October 24, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants