Adapt to change in VNG format from zed/4834 #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automation at https://github.com/brimdata/zui/actions/runs/6726418931 triggered by the merge of brimdata/super#4834 saw a test failure because the exported VNG file size changed slightly due to the changes in that PR. Based on the description in that PR I'm assuming this was expected and indeed the size change is reproducible with just
zq. @nwt since you reviewed that PR I'll merge this change if you'd agree this seems to be in line with your expectations.(I'm guessing the VNG format may change repeatedly in the weeks ahead as more work is being done on the vector engine. I therefore assume a case could be made for dropping the automation that checks the size of the VNG file and treats it as an error when it doesn't match. Personally, though, I like knowing we have something to catch unintentional format changes and I don't mind being the one to react to it when it happens. So if it doesn't offend anyone else, I'm inclined to keep doing this.)