Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect slightly larger VNG export #2885

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Expect slightly larger VNG export #2885

merged 1 commit into from
Nov 8, 2023

Conversation

philrz
Copy link
Contributor

@philrz philrz commented Nov 7, 2023

The Zed pointer hasn't advanced successfully for a while due to the node-pipe build breakages tracked in #2882. But now that's fixed, we've got legit failures like the one adapted to here which I've traced to the changes in brimdata/super#4862. Please approve if the VNG file size change is expected.

@philrz philrz requested a review from nwt November 7, 2023 22:08
@philrz philrz self-assigned this Nov 7, 2023
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to disable this test until VNG is no longer a moving target.

@philrz philrz merged commit 2ffbdd8 into main Nov 8, 2023
3 checks passed
@philrz philrz deleted the bigger-vng-zed-4862 branch November 8, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants