Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-69: remove joda-convert dependency #3131

Merged
merged 1 commit into from
Nov 13, 2024
Merged

CORE-69: remove joda-convert dependency #3131

merged 1 commit into from
Nov 13, 2024

Conversation

davidangb
Copy link
Contributor

Ticket: https://broadworkbench.atlassian.net/browse/CORE-69

The joda-convert dependency is unused; remove it. This obsoletes #3128.

PR checklist

  • Include the JIRA issue number in the PR description and title
  • Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • If you changed anything in model/, then you should publish a new official rawls-model and update rawls-model in Orchestration's dependencies.
  • Get two thumbsworth of PR review
  • Verify all tests go green, including CI tests
  • Squash commits and merge to develop (branches are automatically deleted after merging)
  • Inform other teams of any substantial changes via Slack and/or email

@davidangb davidangb mentioned this pull request Nov 12, 2024
Closed
@davidangb davidangb marked this pull request as ready for review November 13, 2024 12:22
@davidangb davidangb requested a review from a team as a code owner November 13, 2024 12:22
@davidangb davidangb requested review from dvoet and kevinmarete and removed request for a team November 13, 2024 12:22
@davidangb davidangb merged commit 46117c1 into develop Nov 13, 2024
30 checks passed
@davidangb davidangb deleted the da_CORE-69_removeJodaConvert branch November 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinmarete kevinmarete kevinmarete approved these changes

@dvoet dvoet dvoet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidangb @dvoet @kevinmarete