Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-232: move TOS admin enforcement to route level #1622

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Jan 10, 2025

Ticket: https://broadworkbench.atlassian.net/browse/CORE-232

What:

Slightly refactors TOS routes/service such that admin permissions are enforced at the route layer instead of the service layer.

As a welcome side effect, this fixes the GET /api/admin/v1/user/email/{email}/supportSummary API. Before this PR, that API claimed to require resource_type_admin support permissions, but in reality it also required admin permissions, since it called the TOS methods in question.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

@davidangb davidangb marked this pull request as ready for review January 10, 2025 16:40
@davidangb davidangb requested a review from a team as a code owner January 10, 2025 16:40
@davidangb davidangb merged commit 294c19d into develop Jan 10, 2025
26 checks passed
@davidangb davidangb deleted the da_CORE-232_tosSupportPermissions branch January 10, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants