CORE-266: remove group notification v1 #1719
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the notifications library, deletes
GroupAccessRequestNotification
, which was deprecated in 0.10.Context of the overall rollout plan to adopt the SendGrid v3 APIs by February 10:
sendgrid-java
and v3 APIsGroupAccessRequestNotification
used by Sam which allows multiple reply-tos; provide a replacementGroupAccessRequestNotificationV2
that only allows a single reply-to. See CORE-266: enforce a single reply-to address on group-access-request notifications #1717 (this PR)GroupAccessRequestNotificationV2
model in Thurloe. See CORE-235: support GroupAccessRequestNotificationV2 notifications thurloe#372GroupAccessRequestNotificationV2
model in Sam. After this step, Thurloe would no longer ignore the reply-to value sent by Sam; Sam would once again be in control of the reply-to.GroupAccessRequestNotification
from ThurloeGroupAccessRequestNotification
from workbench-libsPR checklist
If you're doing a major or minor version bump to any libraries:
project/Settings.scala
createVersion()
CHANGELOG.md
for those libraries@deprecated
instead of deleting code where possibleIn all cases:
README.md
and theCHANGELOG.md
for any libs you changed withTRAVIS-REPLACE-ME
to auto-update the version string