Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(yarn-detection): detect the presence of yarn and hadoop installations #34

Merged
merged 3 commits into from
May 1, 2024

Conversation

mralaminahamed
Copy link
Contributor

This pull request addresses two main issues:

  1. Fix: yarnpkg not found with collect latest info

    • The issue where the yarnpkg command was not found when trying to collect the latest information has been resolved.
    • The problem was caused by a missing dependency or an outdated version of Yarn installed on the system.
  2. Feat(yarn-detection): detect the presence of yarn and hadoop installations

    • A new feature has been added to detect the presence of yarn and hadoop installations in the current environment.
    • This feature helps to avoid potential conflicts or confusion caused by the yarn CLI name being used by other DevOps tools.

Changes:

  • Updated the installation instructions in the README file to ensure that users have the latest version of Yarn installed.
  • Added a check in the build script to verify the presence of yarnpkg and provide a helpful error message if it's not found.
  • Included a fallback option to install Yarn automatically if it's not present on the system.
  • Implemented a new feature that detects the presence of yarn and hadoop installations in the current environment.

How to Test:

  1. Follow the updated installation instructions in the README file to install the required dependencies, including Yarn.
  2. Run the build script or the command that was previously failing due to the missing yarnpkg command.
  3. Verify that the build process completes successfully and that the latest information is collected correctly.
  4. Test the new yarn and hadoop detection feature by running the appropriate command or script.
  5. Ensure that the detection feature correctly identifies the presence or absence of yarn and hadoop installations.

Additional Notes:

  • If users encounter any issues during the installation process or with the updated build script, they should consult the documentation or reach out to the support team for further assistance.
  • This fix ensures that the application can collect the latest information reliably, regardless of the user's system configuration or the presence of Yarn.
  • The yarn and hadoop detection feature helps to avoid potential conflicts caused by the yarn CLI name being used by other tools.

Closes #27, #33

Please review the changes and let me know if you have any questions or concerns.

@mralaminahamed mralaminahamed changed the title Feat(yarn-detection): detect the presence of yarn and hadoop installations [IN-PROGRESS] Feat(yarn-detection): detect the presence of yarn and hadoop installations Apr 30, 2024
@mralaminahamed
Copy link
Contributor Author

@ai, Kindly review the PR at your convenience.

I have fix testing issue from previous PR #32.

.gitignore Outdated
@@ -1,3 +1,4 @@
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this line?

Text editor files should be in local ignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback. It has been removed now.

@mralaminahamed mralaminahamed changed the title [IN-PROGRESS] Feat(yarn-detection): detect the presence of yarn and hadoop installations Feat(yarn-detection): detect the presence of yarn and hadoop installations Apr 30, 2024
index.js Outdated Show resolved Hide resolved
@ai ai merged commit 0aa5fa5 into browserslist:main May 1, 2024
5 checks passed
@ai
Copy link
Member

ai commented May 1, 2024

Thanks. Released in 1.0.14.

@mralaminahamed
Copy link
Contributor Author

working as expected

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx update-browserslist-db@latest is broken due to yarnpkg: command not found
2 participants