Update hero element & improve loading performance #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KyleMit
reviewed
Aug 3, 2023
KyleMit
reviewed
Aug 3, 2023
KyleMit
reviewed
Aug 3, 2023
JamesMitofsky
force-pushed
the
18-update-hero-on-landing-page-to-use-a-blob
branch
from
95e627b to
1cd36d6
Compare
JamesMitofsky
force-pushed
the
18-update-hero-on-landing-page-to-use-a-blob
branch
from
9b51bc7 to
8f72980
Compare
|
I think you're right, @KyleMit, about not needing to use canvas for this (our comment thread), but short of implementing a regression while having also made a few other tiny updates, I'm excited to merge this into the main branch. :) I'm going to close this pull request, but what do you think if I leave #18 open? |
|
I also admit to be a little chasing this score 😅
|
|
Yeah, not a regression - good to roll forward. Just something to consider especially as you start animating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #18
Motivation of changes
Animated landing page
Although the hero image from before was cute, these changes help performance while also moving the site toward an animated landing page. Yes, the dot is currently drawn by a HTML canvas, but it now it's effectively ready to be animated when the page loads or on user interaction.
Possible future options
3D animation using a library like Svelte Cubed or Svelthree, but neither of these have been recently pushed to.