fix: missing error_message when reporting client's unknown error #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
reviewed
Oct 22, 2024
| metricsEventData = .unknownError( | ||
| .init( | ||
| apiId: apiId, | ||
| labels: labels.merging( |
There was a problem hiding this comment.
I think the tag is also missing in the metric event labels.
Can you confirm?
There was a problem hiding this comment.
The tag is inserted here
and we are using merging() to merge new changes to the input map
cre8ivejp
deleted the
fix/missing-error-message-when-reporting-unknown-error
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the missing
error_messagewhen reporting an unknown error from SDK code (it is different case with unknown error from the server API)