Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Instead of Docker use Nix to build release #8401

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PsychoPunkSage
Copy link
Contributor

Current behavior

Currently, we build ockam release assets (Nif build) using our Docker builder image,

Proposed changes

deprecate usage of docker and use Nix instead
Closes #5943

@PsychoPunkSage PsychoPunkSage requested a review from a team as a code owner August 9, 2024 04:20
Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go @PsychoPunkSage

.github/workflows/release-draft-binaries.yml Show resolved Hide resolved
.github/workflows/release-draft-binaries.yml Show resolved Hide resolved
.github/workflows/release-draft-binaries.yml Outdated Show resolved Hide resolved
.github/workflows/release-draft-binaries.yml Outdated Show resolved Hide resolved
.github/workflows/release-draft-binaries.yml Outdated Show resolved Hide resolved
.github/workflows/release-draft-binaries.yml Outdated Show resolved Hide resolved
@PsychoPunkSage
Copy link
Contributor Author

Hi @metaclips
i have done the desired changes
Please have a look

I need help in few things:

How to test the workflow (I'm making)? I'm not aware of any to do it.... Can you tell how to do it on my system

I'm following nix pills to get basics of nix. Is it right resource? Additionally can you share some more resources related to nix which I can follow to better understand it?

@metaclips
Copy link
Member

metaclips commented Aug 19, 2024

Hi @metaclips i have done the desired changes Please have a look

I need help in few things:

How to test the workflow (I'm making)? I'm not aware of any to do it.... Can you tell how to do it on my system

I'm following nix pills to get basics of nix. Is it right resource? Additionally can you share some more resources related to nix which I can follow to better understand it?

How to test the workflow (I'm making)? I'm not aware of any to do it.... Can you tell how to do it on my system

You can test on your repository, should be straightforward as you made changes only to the workflow that builds binaries, on your repository, this is the workflow that creates the draft binaries https://github.com/PsychoPunkSage/ockam/actions/workflows/release-draft-binaries.yml

I use this website to learn more about Nix https://nix-community.github.io/awesome-nix/

@PsychoPunkSage
Copy link
Contributor Author

You can test on your repository, should be straightforward as you made changes only to the workflow that builds binaries, on your repository, this is the workflow that creates the draft binaries https://github.com/PsychoPunkSage/ockam/actions/workflows/release-draft-binaries.yml

I use this website to learn more about Nix https://nix-community.github.io/awesome-nix/

Thank you for help :)

Are there any changes required (in this PR)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build our release assets with Nix instead of Docker
2 participants