Move geometry from metadata of a component to a domain geometricData
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-maurer
added
ISE
…nd the data itself
… 2. We plan to remove all keys which are currently not ready for production.
christoph-maurer
force-pushed
the
move-geometry-to-domain
branch
from
d6c4902 to
bcfab0d
Compare
… the simple geometric information of `geometricData.json`. When a resource includes the LOD, then it can become part of `geometric.json` and GraphQL.
… resources is at the level of `geometric.json/data`
… this is treated in `#/$defs/componentCharacteristics/properties/definitionOfSurfacesAndPrimeDirection` of the assembly and of the subcomponents.
…h building envelopes.
…de `thickness` as mirrored value.
christoph-maurer
force-pushed
the
move-geometry-to-domain
branch
from
089a53e to
5dcda2b
Compare
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several servers may have geometric data about a component. Geometric data can be a https resource or a key-value pair like
"thickness": 0.004. The product data network needs to offer a search for components with a certain thickness. Therefore, I have created the domaingeometricDatain the API specifications and JSON schemas and updated the examples and tests. This allows a search for a certain thickness in GraphQL and to return the thickness as a JSON blob.Resolves #314