Skip to content

Commit

Permalink
remove guppy-git
Browse files Browse the repository at this point in the history
  • Loading branch information
vankasteelj committed Apr 8, 2016
1 parent 3d68934 commit b2c8244
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 17 deletions.
18 changes: 2 additions & 16 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const nwVersion = '0.12.2',
const gulp = require('gulp'),
glp = require('gulp-load-plugins')(),
runSequence = require('run-sequence'),
guppy = require('git-guppy')(gulp),
del = require('del'),

nwBuilder = require('nw-builder'),
Expand Down Expand Up @@ -379,26 +378,13 @@ gulp.task('compress', () => {
});

// prevent commiting if conditions aren't met and force beautify (bypass with `git commit -n`)
gulp.task('pre-commit', () => {
const lintfilter = glp.filter(['*.js']);

return gulp.src(guppy.src('pre-commit'), {
base: './'
})
// verify lint
.pipe(lintfilter)
.pipe(glp.jshint('.jshintrc'))
.pipe(glp.jshint.reporter('default'))
.pipe(glp.jshint.reporter('fail')) // TODO: prevent the 'throw err' message log on jshint error, it's annoying
// commit
.pipe(gulp.dest('./'));
});
gulp.task('pre-commit', ['jshint']);

// check entire sources for potential coding issues (tweak in .jshintrc)
gulp.task('jshint', () => {
return gulp.src(['gulpfile.js', 'src/app/lib/*.js', 'src/app/lib/**/*.js', 'src/app/vendor/videojshooks.js', 'src/app/vendor/videojsplugins.js', 'src/app/*.js'])
.pipe(glp.jshint('.jshintrc'))
.pipe(glp.jshint.reporter('default'))
.pipe(glp.jshint.reporter('jshint-stylish'))
.pipe(glp.jshint.reporter('fail'));
});

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"bower": "^1.7.7",
"del": "^2.2.0",
"jshint": "^2.9.1",
"git-guppy": "^1.1.0",
"jshint-stylish": "^2.1.0",
"git-rev": "^0.2.1",
"gulp": "^3.9.0",
"gulp-stylus": "^2.3.1",
Expand Down

0 comments on commit b2c8244

Please sign in to comment.