Fix chromecast subtitle position

[brianardiles]

No description provided.

[vankasteelj]

What does your fork changes exactly? I think you should rather open an issue/PR on main module, for it to remain maintained and updated.

[brianardiles]

@vankasteelj My fork change this:
VTT_BODY.push(module.exports.formatTime(caption.startTimeMicro) + ' --> ' + module.exports.formatTime(caption.endTimeMicro));

to

VTT_BODY.push(module.exports.formatTime(caption.startTimeMicro) + ' --> ' + module.exports.formatTime(caption.endTimeMicro) + ' line:90%');

This edit the subs.vtt and add margin from bottom with this change reading is much easier

[sulaimanob]

can you give me .exe for your fix

[vankasteelj]

I'm uncomfortable with this. I know it breaks DLNA on LG, but that probably can be fixed. My main concern here is the fork of node-captions without a PR being sent back upstream.

[Breaking1]

This was fixed when i got an update on my Chromecast, as you can see here i think it is a Chromecast firmware issue and an update was provided to fix this.

https://productforums.google.com/forum/?hl=da#!topic/chromecast/Qe76EGhzlII;context-place=forum/chromecast

[brianardiles]

@Breaking1 No, editing the vtt subtitles file you can put the text in any position on the screen.

@vankasteelj I can think of another way to modify the script in pt

@sulaimanob go to C:\Users\YOURUSERNAMME\AppData\Local\Popcorn-Time\node_modules\node-captions\lib
open vtt.js file search this line "VTT_BODY.push(module.exports.formatTime(caption.startTimeMicro) + ' --> ' + module.exports.formatTime(caption.endTimeMicro));"

and replace with VTT_BODY.push(module.exports.formatTime(caption.startTimeMicro) + ' --> ' + module.exports.formatTime(caption.endTimeMicro) + ' line:90%');

now restart pt

[brianardiles]

@vankasteelj check the last commit in node-captions 11 Aug 2015

[vankasteelj]

Okay, I'm voting for this, apparently node-captions is dead (maintainer not online for a year) @xaiki you ok merging this too?

(not merging like it's now, it has leftovers from a merge that broke dlna, only keep the actual changes from brai4u: "node-captions": "git+https://github.com/brai4u/node-captions.git",)

[xaiki]

why do we have all those commits ? didn't you revert those in the firstplace ?

[xaiki]

changes look ok, but i have no tv to test on, a few nitpicks:

• @brai4u you should own node-captions and publish it on NPM
• @brai4u you should split out your changes and work with @vankasteelj to get these changes not to break his TV... (or any others fwiw)

[brianardiles]

Search on google "problem chromecast subtitles popcorn time" and should find pics like this

I used the version with my commit and works like this

[xaiki]

can we solve the nitpicks and merge this ?

[xaiki]

can we solve the nitpicks and merge this ?

[z11h]

It would be great if we can merge this!

[xaiki]

@zakariaridouh do you want to do the cleanup @vankasteelj asked for ? go for it =D

[vankasteelj]

@brai4u you think you can also merge the PRs that are made on the main repo, and publish your version to NPM (I don't like the idea of depending on you not deleting your repo^^) ?