fix conversion from int to bool in assert statement, thereby fixing t…

…he error handling/reporting Signed-off-by: Bruno Vavala <[email protected]>
bvavala · Apr 23, 2024 · 3d28539 · 3d28539
1 parent 9144ca6
commit 3d28539
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/common/crypto/sig_public_key.cpp b/common/crypto/sig_public_key.cpp
@@ -309,6 +309,7 @@ int pcrypto::sig::PublicKey::VerifySignature(
         return -1;
 
     // Verify
+    // ECDSA_do_verify() returns 1 for a valid sig, 0 for an invalid sig and -1 on error
     return ECDSA_do_verify(hash.data(), hash.size(), sig.get(), key_);
 }  // pcrypto::sig::PublicKey::VerifySignature
 

diff --git a/python/pdo/test/storage.py b/python/pdo/test/storage.py
@@ -58,6 +58,7 @@ def verify_store_signature(store_response, duration, verifying_key) :
     decoded_signature = base64.urlsafe_b64decode(store_response['signature'])
 
     vk = crypto.SIG_PublicKey(verifying_key)
+    # VerifySignature returns 1 for a valid sig, 0 for an invalid sig and -1 on error
     return vk.VerifySignature(signing_hash, decoded_signature)
 
 # -----------------------------------------------------------------
@@ -76,7 +77,7 @@ def verify_store_signature(store_response, duration, verifying_key) :
     result = client.store_blocks([block_data], duration=default_duration)
     assert result
 
-    assert verify_store_signature(result, default_duration, client.verifying_key)
+    assert (1 == verify_store_signature(result, default_duration, client.verifying_key))
 
     block_ids = result['block_ids']
     assert block_ids and len(block_ids) == 1
@@ -109,7 +110,7 @@ def verify_store_signature(store_response, duration, verifying_key) :
     result = client.store_blocks(block_data, duration=default_duration)
     assert result
 
-    assert verify_store_signature(result, default_duration, client.verifying_key)
+    assert (1 == verify_store_signature(result, default_duration, client.verifying_key))
 
     block_ids = result['block_ids']
     logger.info('RESULT: %s', result)