Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed terminal issues #38

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

sahilf637
Copy link

@sahilf637 sahilf637 commented Jan 18, 2025

Fixed terminal Issue

Fixes #36

Issue

  • The React terminal exhibits abnormal behavior, including non-responsiveness and requiring specific clicks to gain focus.

Fix Details

  • Adjusted CSS properties to address layout and overlay issues:
    • Ensured the mainScreen container doesnt overlays the terminal.
    • Applied z-index to prioritize the terminal window appropriately.

Additional Context

  • This fix was achieved through modifications to CSS properties of the terminal and main screen containers.
  • A video demonstration of the fixed behavior is attached below.

Video Demonstration

Screencast.from.2025-01-18.15-23-40.webm

@Shubh942 Shubh942 changed the base branch from main to feature/gdbui-2025 January 18, 2025 10:19
@Shubh942
Copy link
Contributor

Great job, @sahilf637 ! After this PR is merged, please set the base branch to feature/gdbui-2025

@Shubh942 Shubh942 merged commit 67bd56f into c2siorg:feature/gdbui-2025 Jan 18, 2025
2 checks passed
@sahilf637
Copy link
Author

@Shubh942 ok

@sahilf637 sahilf637 deleted the main branch January 18, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal Interaction
2 participants