Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what this repo represents #6

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Clarify what this repo represents #6

merged 2 commits into from
Feb 5, 2024

Conversation

inodb
Copy link
Member

@inodb inodb commented Feb 5, 2024

Still some confusion about this being called legacy, so made some changes in phrasing

@inodb inodb added the documentation Improvements or additions to documentation label Feb 5, 2024
@inodb inodb merged commit 8515c49 into main Feb 5, 2024
1 check passed
@inodb inodb deleted the clarify-core-use branch February 5, 2024 21:32
Copy link
Contributor

@sheridancbio sheridancbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If the entire cbioportal-core repository is intended to become deprecated code then maybe we don't need to worry about stripping away any of the other services in cbioportal-core (such as the webservice.do functionality). But if there are dependencies which we think deserve continued support after deprecation we might try to identify those now so we can give better guidance to the community on what portions of this repo will be eventually dropped v. which will continue to be supported.

@inodb
Copy link
Member Author

inodb commented Feb 5, 2024

@sheridancbio That's a good point re describing exactly what we intend to become deprecated. I'm not entirely sure

At the moment webservice.do is no longer working, so if no one complaints that would be one of the things that'll be deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants