Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiki] Update toolchain description #1343

Merged
merged 16 commits into from
Nov 10, 2022
Merged

[wiki] Update toolchain description #1343

merged 16 commits into from
Nov 10, 2022

Conversation

franciscozdo
Copy link
Collaborator

@franciscozdo franciscozdo commented Oct 16, 2022

I have tried to build and run Mimiker on my machine. It wasn't easy due to fact that the wiki is outdated.

I have prepared a script to install all needed software automatically (it will be nice feature for the newcomers).

@franciscozdo
Copy link
Collaborator Author

@cahirwpz Could you check if the list of tools I have prepared is complete? There are probably some requirements I have not found because I have build Mimiker successfully only for Aarch64.

List of needed software is prepared on arch based distribution and for
Aarch64 development.
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
wiki/docs/toolchain.md Outdated Show resolved Hide resolved
@franciscozdo
Copy link
Collaborator Author

Thank you all for the review. I have updated the wiki page with only a basic info. Other detailed information is available in Dockerfile (which is linked in wiki).

install-tools.sh Outdated Show resolved Hide resolved
@franciscozdo
Copy link
Collaborator Author

I have moved dependencies from the docker file and install script to the files: packages-ci.txt (used in Dockerfile) and packages.txt and packages-backports.txt (used in install-tools.sh).

Now the only supported distribution for install script is Debian bullseye with configured backports repositories.

Copy link
Collaborator

@pj1031999 pj1031999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.
LGTM

Dockerfile Outdated
Comment on lines 8 to 13
RUN apt-get install -y --no-install-recommends -t bullseye-backports $(cat packages-ci.txt)
RUN apt-key adv --fetch-keys https://apt.llvm.org/llvm-snapshot.gpg.key
RUN echo "deb http://apt.llvm.org/bullseye/ llvm-toolchain-bullseye-14 main" > \
/etc/apt/sources.list.d/llvm-14.list && apt-get update
RUN apt-get install -y --no-install-recommends -t bullseye-backports \
clang-14 clang-format-14 llvm-14 lld-14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can compress it into single step to avoid unnecessary layers in final container.

install-tools.sh Outdated Show resolved Hide resolved
install-tools.sh Outdated Show resolved Hide resolved
@pj1031999
Copy link
Collaborator

@cahirwpz PTAL

packages-ci.txt Outdated
@@ -0,0 +1 @@
git make ccache cpio curl gnupg universal-ctags cscope socat patch gperf quilt byacc python3 python3-pip python3-virtualenv device-tree-compiler tmux lsb-release qemu-system-aarch64 qemu-system-riscv64 libsdl2-2.0-0 libpulse0
Copy link
Owner

@cahirwpz cahirwpz Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file. You can fix missing libraries after installing custom packages with dpkg using apt-get install -f.

packages-backports.txt Outdated Show resolved Hide resolved
packages.txt Outdated Show resolved Hide resolved
@cahirwpz
Copy link
Owner

cahirwpz commented Nov 9, 2022

Does this PR solve #494 ?

Copy link
Owner

@cahirwpz cahirwpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cahirwpz cahirwpz merged commit 3da5648 into master Nov 10, 2022
@cahirwpz cahirwpz deleted the wiki branch November 10, 2022 16:10
@cahirwpz cahirwpz added the accepted accepted by the maintainer for code review label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted by the maintainer for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants