-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cancelledBy input to cancellation page #18770
base: main
Are you sure you want to change the base?
Conversation
@iharsh02 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/20/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (01/20/25)1 label was added to this PR based on Keith Williams's automation. |
@Praashh sorry for the last PR , what happened their was not suppose to happen truly embarrassing 🙏 |
setShowVerificationDialog(false); | ||
setVerificationError(""); | ||
setVerificationEmail(""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we setting these ? can you please tell me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case user , tried to verify with an incorrect email, saw an error msg , then close the dialog and later user open the cancel dialog (so he will not see the same error msg again before verifying the email)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! tagging @anikdhabal for a final touch..
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
cal-5045.mp4