Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cancelledBy input to cancellation page #18770

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iharsh02
Copy link

@iharsh02 iharsh02 commented Jan 20, 2025

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings
cal-5045.mp4

Copy link

vercel bot commented Jan 20, 2025

@iharsh02 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 20, 2025
@graphite-app graphite-app bot requested a review from a team January 20, 2025 17:57
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix cal 5045". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Jan 20, 2025
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking i18n area: i18n, translations labels Jan 20, 2025
@iharsh02 iharsh02 changed the title Fix cal 5045 feat: Add cancelledBy input to cancellation page Jan 20, 2025
Copy link

graphite-app bot commented Jan 20, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/20/25)

1 label was added to this PR based on Keith Williams's automation.

@iharsh02
Copy link
Author

@Praashh sorry for the last PR , what happened their was not suppose to happen truly embarrassing 🙏

@Praashh Praashh self-assigned this Jan 20, 2025
Comment on lines +188 to +190
setShowVerificationDialog(false);
setVerificationError("");
setVerificationEmail("");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we setting these ? can you please tell me?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case user , tried to verify with an incorrect email, saw an error msg , then close the dialog and later user open the cancel dialog (so he will not see the same error msg again before verifying the email)

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tagging @anikdhabal for a final touch..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync ✨ feature New feature or request i18n area: i18n, translations Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5045] Add cancelledBy input to cancellation page
2 participants