Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip confirm step in booker #18773

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: skip confirm step in booker #18773

wants to merge 21 commits into from
+253 −115

Conversation

SomayChauhan
Copy link
Member

@SomayChauhan SomayChauhan commented Jan 21, 2025 •
edited
Loading

What does this PR do?

with Turnstile disabled

https://www.loom.com/share/afbfc32af32f4fad94c1e9f80c832827?sid=4b5aee5a-5019-4eaf-bda8-5e9ca17be7e3

with Turnstile enabled

https://www.loom.com/share/ad9fb69d1d544bdaa1923e44f86a733f?sid=b18bd4a0-e53a-43e3-a82a-cb3175d67c20

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jan 21, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 5:50am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 5:50am

@SomayChauhan SomayChauhan marked this pull request as ready for review January 23, 2025 06:47
@graphite-app graphite-app bot requested review from a team January 23, 2025 06:47
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking ✨ feature New feature or request labels Jan 23, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 23, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (01/23/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Udit-takkar
Udit-takkar reviewed Jan 23, 2025
View reviewed changes
packages/features/bookings/lib/getBookingResponsesSchema.ts Outdated
Comment on lines 161 to 167
const isRequired = hidden
? false
: isFieldApplicableToCurrentView
? checkOptional
? true
: bookingField.required
: false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should simplify this

Udit-takkar
Udit-takkar reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type checks are failing

@linear Linear
Copy link

linear bot commented Jan 23, 2025

CAL-4943 If all information for "confirm" step is provided skip step

@dosubot dosubot bot added this to the v4.10 milestone Jan 23, 2025
@SomayChauhan SomayChauhan marked this pull request as draft January 23, 2025 09:31
@github-actions github-actions bot added the High priority Created by Linear-GitHub Sync label Jan 23, 2025
@SomayChauhan SomayChauhan marked this pull request as ready for review January 23, 2025 10:32
@SomayChauhan SomayChauhan added ready-for-e2e and removed platform Anything related to our platform plan labels Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

E2E results are ready!

@keithwillcode keithwillcode added the platform Anything related to our platform plan label Jan 24, 2025
@ThyMinimalDev
Copy link
Contributor

looking good, we might want to add en e2e test with this flow using the iframe embed in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udit-takkar Udit-takkar Udit-takkar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.

[CAL-4943] If all information for "confirm" step is provided skip step
4 participants
@SomayChauhan @ThyMinimalDev @Udit-takkar @keithwillcode