Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release r1.1 #16

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

yamamoto0104
Copy link
Contributor

@yamamoto0104 yamamoto0104 commented Dec 11, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Create release branch r1.1 for v0.1.0-alpha.1 and include CHANGELOG

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@eric-murray
Copy link
Contributor

@yamamoto0104
I would suggest to approve and merge #20 before merging this PR so that the alpha version includes the updated error codes

@yamamoto0104
Copy link
Contributor Author

Hello @eric-murray
I'm fine with your proposal.
we are revieing #20 internally and feedback later.

@yamamoto0104
Copy link
Contributor Author

Hello @eric-murray
I think 0.1alpha1 can be v0.1alpha1

@eric-murray eric-murray changed the title Release v0.1.0 Release r1.1 Jan 2, 2025
@eric-murray
Copy link
Contributor

@yamamoto0104

The following still needs to be done before this can be approved and merged:

  • Merge Adding API-Readiness-Checklist #18 so that the API readiness checklist is in the release
  • Update links in the YAML that reference main to reference the release tag r1.1 instead
    • e.g. link to Number_Recycling_scenario_1.png should be: src="https://raw.githubusercontent.com/camaraproject/NumberRecycling/r1.1/documentation/API_documentation/assets/Number_Recycling_scenario_1.png"
    • Include @camaraproject/release-management_maintainers in the list of reviewers for this PR

@yamamoto0104 yamamoto0104 requested a review from a team January 2, 2025 14:32
@yamamoto0104
Copy link
Contributor Author

Hello @eric-murray

Thank you for your comments. I updated the link and added @camaraproject/release-management_maintainers.

  • Update links in the YAML that reference main to reference the release tag r1.1 instead

    • e.g. link to Number_Recycling_scenario_1.png should be: src="https://raw.githubusercontent.com/camaraproject/NumberRecycling/r1.1/documentation/API_documentation/assets/Number_Recycling_scenario_1.png"
    • Include @camaraproject/release-management_maintainers in the list of reviewers for this PR

@Masa8106 Could you merge #18 ?

@Masa8106
Copy link
Contributor

Masa8106 commented Jan 3, 2025

@yamamoto0104 Yes. I have merged PR#18. Please check it.

@yamamoto0104
Copy link
Contributor Author

Hello @eric-murray and @camaraproject/release-management_maintainers
I updated README.MD for r1.1. Please check this.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Herbert Damker <[email protected]>
grgpapadopoulos
grgpapadopoulos previously approved these changes Jan 9, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

**This is the first alpha version of the KYC APIs.**

- [number-recycling v0.1.0-alpha.1](https://github.com/camaraproject/NumberRecycling/blob/r1.1/code/API_definitions/number-recycling.yaml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is no link expected, the links are in the section for the number-recycling v0.1.0-alpha.1 API.

See https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/CHANGELOG_TEMPLATE.md
for the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hdamker
CHANGELOG.md was updated based on the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hdamker
M3 target date is this Friday. Could you approve this PR if there is any issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yamamoto0104 the review issue camaraproject/ReleaseManagement#133 is actually assigned to @FrimanJan. And don't worry, the deadline only requires to have the PR provided until Friday for review by ReleaseManagement. That you have achieved 👍

Copy link
Contributor

@Masa8106 Masa8106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Masa8106
Copy link
Contributor

@maxl2287 , @eric-murray , @grgpapadopoulos
Would you review this for approval? As discussed in the KYC sub group meeting, I am waiting for your approval to confirm your review results and will merge it tomorrow.

@hdamker hdamker requested a review from a team January 21, 2025 17:29
@hdamker
Copy link
Contributor

hdamker commented Jan 21, 2025

@maxl2287 , @eric-murray , @grgpapadopoulos
Would you review this for approval? As discussed in the KYC sub group meeting, I am waiting for your approval to confirm your review results and will merge it tomorrow.

@yamamoto0104 It's good to collect the approvals from your codeowner colleagues. But please wait with your merge for the approval from ReleaseManagement. The deadline on Friday requires only to provide the PR for RM approval, not to publish the pre-release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update scope of repository within README.
6 participants