-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release r1.1 #16
base: main
Are you sure you want to change the base?
Release r1.1 #16
Conversation
@yamamoto0104 |
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Co-authored-by: Eric Murray <[email protected]>
Hello @eric-murray |
Hello @eric-murray |
The following still needs to be done before this can be approved and merged:
|
Hello @eric-murray Thank you for your comments. I updated the link and added @camaraproject/release-management_maintainers.
@Masa8106 Could you merge #18 ?
|
@yamamoto0104 Yes. I have merged PR#18. Please check it. |
Hello @eric-murray and @camaraproject/release-management_maintainers |
Co-authored-by: Herbert Damker <[email protected]>
CHANGELOG.md
Outdated
|
||
**This is the first alpha version of the KYC APIs.** | ||
|
||
- [number-recycling v0.1.0-alpha.1](https://github.com/camaraproject/NumberRecycling/blob/r1.1/code/API_definitions/number-recycling.yaml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is no link expected, the links are in the section for the number-recycling v0.1.0-alpha.1 API.
See https://github.com/camaraproject/ReleaseManagement/blob/main/documentation/CHANGELOG_TEMPLATE.md
for the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hdamker
CHANGELOG.md was updated based on the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hdamker
M3 target date is this Friday. Could you approve this PR if there is any issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yamamoto0104 the review issue camaraproject/ReleaseManagement#133 is actually assigned to @FrimanJan. And don't worry, the deadline only requires to have the PR provided until Friday for review by ReleaseManagement. That you have achieved 👍
Co-authored-by: Herbert Damker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maxl2287 , @eric-murray , @grgpapadopoulos |
@yamamoto0104 It's good to collect the approvals from your codeowner colleagues. But please wait with your merge for the approval from ReleaseManagement. The deadline on Friday requires only to provide the PR for RM approval, not to publish the pre-release. Thanks! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Create release branch r1.1 for v0.1.0-alpha.1 and include CHANGELOG