Skip to content

Commit

Permalink
Fix "Implicitly marking parameter as nullable" deprecation messages g…
Browse files Browse the repository at this point in the history
…enerated when running under PHP 8.4. See GitHub Issue apereo#442.
  • Loading branch information
campbell-m committed Sep 1, 2024
1 parent 690d431 commit 6ef19a1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions source/CAS.php
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class phpCAS
*/
public static function client($server_version, $server_hostname,
$server_port, $server_uri, $service_base_url,
$changeSessionID = true, \SessionHandlerInterface $sessionHandler = null
$changeSessionID = true, ?\SessionHandlerInterface $sessionHandler = null
) {
phpCAS :: traceBegin();
if (is_object(self::$_PHPCAS_CLIENT)) {
Expand Down Expand Up @@ -402,7 +402,7 @@ public static function client($server_version, $server_hostname,
*/
public static function proxy($server_version, $server_hostname,
$server_port, $server_uri, $service_base_url,
$changeSessionID = true, \SessionHandlerInterface $sessionHandler = null
$changeSessionID = true, ?\SessionHandlerInterface $sessionHandler = null
) {
phpCAS :: traceBegin();
if (is_object(self::$_PHPCAS_CLIENT)) {
Expand Down
2 changes: 1 addition & 1 deletion source/CAS/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ public function __construct(
$server_uri,
$service_base_url,
$changeSessionID = true,
\SessionHandlerInterface $sessionHandler = null
?\SessionHandlerInterface $sessionHandler = null
) {
// Argument validation
if (gettype($server_version) != 'string')
Expand Down

0 comments on commit 6ef19a1

Please sign in to comment.