feat(footer): get rid of fixed height

trying to stay close to original height/layout
camptocamp · Feb 13, 2024 · 18d03c5 · 18d03c5
1 parent 1413eb8
commit 18d03c5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/apps/datahub/src/app/common/footer/mel-datahub-footer.component.html b/apps/datahub/src/app/common/footer/mel-datahub-footer.component.html
@@ -1,10 +1,10 @@
 <footer class="flex flex-col">
   <div
-    class="flex flex-row flex-wrap min-h-36 h-28 p-4 px-8 text-white justify-between items-center"
-    [style.background]="'url(' + iconsUrl + 'bg-footer.png)'"
+    class="flex flex-row flex-wrap min-h-32 p-4 px-8 text-white justify-between items-center"
+    style.background="url({{ iconsUrl }}bg-footer.png)"
   >
     <div class="flex flex-row items-center gap-6 flex-wrap">
-      <span class="text-xs leading-3" translate=""
+      <span class="text-sm leading-3" translate=""
         >mel.common.footer.follow</span
       >
       <ul class="flex flex-row gap-4">
@@ -98,11 +98,19 @@
       </ul>
     </div>
     <div class="flex flex-row items-center">
-      <img class="h-20 mr-8" [src]="iconsUrl + 'finance_ue.png'" />
-      <img class="h-28 mb-2" [src]="iconsUrl + 'france_relance.png'" />
+      <img
+        class="h-20 mr-8"
+        src="{{ iconsUrl }}finance_ue.png"
+        [alt]="'mel.common.footer.logo.financeUE' | translate"
+      />
+      <img
+        class="h-24"
+        src="{{ iconsUrl }}france_relance.png"
+        [alt]="'mel.common.footer.logo.franceRelance' | translate"
+      />
     </div>
     <div class="flex flex-row items-center">
-      <span class="text-xs leading-3 max-w-[352px] mr-10" translate=""
+      <span class="text-xs leading-3 mr-10" translate=""
         >mel.common.footer.newsletter.inform</span
       >
       <a

diff --git a/apps/datahub/src/assets/i18n/en_MEL.json b/apps/datahub/src/assets/i18n/en_MEL.json
@@ -3,6 +3,8 @@
   "mel.common.footer.contact": "Contact us",
   "mel.common.footer.follow": "Follow us !",
   "mel.common.footer.legal": "Legal mentions",
+  "mel.common.footer.logo.financeUE": "",
+  "mel.common.footer.logo.franceRelance": "",
   "mel.common.footer.newletter.signup": "Sign up to the newsletter",
   "mel.common.footer.news": "Last news",
   "mel.common.footer.newsletter.inform": "Subscribe to the newsletter and stay informed of MEL's last news !",

diff --git a/apps/datahub/src/assets/i18n/fr_MEL.json b/apps/datahub/src/assets/i18n/fr_MEL.json
@@ -3,6 +3,8 @@
   "mel.common.footer.contact": "Contactez-nous",
   "mel.common.footer.follow": "Suivez-nous !",
   "mel.common.footer.legal": "Mentions légales",
+  "mel.common.footer.logo.financeUE": "Financé par l'Union européenne",
+  "mel.common.footer.logo.franceRelance": "France Relance",
   "mel.common.footer.newletter.signup": "S'inscrire à l'infolettre",
   "mel.common.footer.news": "Actualités",
   "mel.common.footer.newsletter.inform": "Restez informés de l'actualité de la MEL en vous inscrivant à l'infolettre !",