[Dataset page] Main block #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkohr
force-pushed
the
dataset-abstract
branch
2 times, most recently
from
4927497 to
3a11f0d
Compare
Angi-Kinas
reviewed
Feb 8, 2024
There was a problem hiding this comment.
This looks great already! Thanks a lot!
The most significant thing I discovered while testing, was the disabled style of the favorite button when being clicked and also on hover on all the buttons. You can check their design system for reference (https://zeroheight.com/3b9e7ec84/p/937c12-boutons/b/32e1a2).
apps/datahub/src/app/common/button-primary/button-primary.component.html
Show resolved
Hide resolved
apps/datahub/src/app/common/favorites/heart-toggle/heart-toggle.component.ts
Show resolved
Hide resolved
apps/datahub/src/app/common/favorites/heart-toggle/heart-toggle.component.ts
Show resolved
Hide resolved
and display list with gn-ui components for now
…e-star by favorite-heart allowing to reuse the connect tooltip from gn-ui
needs higher version of gn-ui
…ommon classes into mel-card
tkohr
force-pushed
the
dataset-abstract
branch
from
5a05cf0 to
f47db9b
Compare
Angi-Kinas
approved these changes
Feb 8, 2024
|
Thanks for the reviews @Angi-Kinas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the section visible on the screenshot below.
Amongst others
button-primary.componentthat can be reused in other parts of the app. I decided for an angular component instead of a tailwind component to centralize the indication of the icons' path.To-dos: