Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icons #12

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Fix icons #12

merged 3 commits into from
Feb 8, 2024

Conversation

tkohr
Copy link
Member

@tkohr tkohr commented Feb 8, 2024 •
edited
Loading

PR should fix the icons on the deployed app using relative path for assets.

Also removes hover on disabled buttons and adds the LOGIN_URL from the datahub config (used in the tooltip that proposes the login).

Angi-Kinas
Angi-Kinas approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the icons 👍

@tkohr tkohr merged commit b351dac into main Feb 8, 2024
7 checks passed
@tkohr tkohr deleted the fix-icons branch February 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkohr @Angi-Kinas