feat(DH): Add favorite card #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angi-Kinas
force-pushed
the
favorite-card
branch
from
1214a31 to
d36a09f
Compare
Angi-Kinas
commented
Feb 1, 2024
Merged
add metadata quality indicator
Angi-Kinas
force-pushed
the
favorite-card
branch
from
c75863c to
d9a0880
Compare
add hover style shadow
and favorites exists, otherwise show last-created card. Add info icon, comment tests for fav-card, remove favorite star.
tkohr
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Thanks for the clean implementation @Angi-Kinas! I left some minor comments inline. Also noticed a small glitch of the metadata-quality.component displaying behind the neighboring card when testing. Do you think you could fix this?
apps/datahub/src/app/common/metadata-quality/mel-datahub-metadata-quality.component.html
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/common/metadata-quality/mel-datahub-metadata-quality.component.ts
Show resolved
Hide resolved
.../src/app/common/results-list-item/results-card-favorite/results-card-favorite.component.html
Show resolved
Hide resolved
.../src/app/common/results-list-item/results-card-favorite/results-card-favorite.component.html
Outdated
Show resolved
Hide resolved
.../src/app/common/results-list-item/results-card-favorite/results-card-favorite.component.html
Outdated
Show resolved
Hide resolved
.../src/app/common/results-list-item/results-card-favorite/results-card-favorite.component.html
Outdated
Show resolved
Hide resolved
.../src/app/common/results-list-item/results-card-favorite/results-card-favorite.component.html
Outdated
Show resolved
Hide resolved
| @@ -12,7 +12,8 @@ import { SortByField } from 'geonetwork-ui/libs/common/domain/src/lib/model/sear | |||
| export class SearchHeaderComponent { | |||
| constructor( | |||
| public routerFacade: RouterFacade, | |||
| private searchService: SearchService | |||
| private searchService: SearchService, | |||
| public favoritesService: FavoritesService | |||
There was a problem hiding this comment.
I think the FavoriteService is not needed here anymore.
There was a problem hiding this comment.
It's still needed because it's used in the template to figure out if there are any favorites and set the "favoritesOnly" input.
remove unused class, add tests for not logged in, make quality overlay appearing above cards.
tkohr
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks for the adaptions and the latest fix @Angi-Kinas ! Everything works fine on my side :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR styles the "results-card-favorite"-component to fit the given design.
This is how it looks:
Note: