[Dataset page] : Filter by category in dataset page #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkohr
reviewed
Jun 26, 2024
apps/datahub/src/app/dataset/dataset-information/dataset-information.component.html
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/dataset/dataset-information/dataset-information.component.ts
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/dataset/dataset-information/dataset-information.component.ts
Outdated
Show resolved
Hide resolved
cmoinier
force-pushed
the
filter-by-category-ds-page
branch
from
a6cdb13 to
55fc703
Compare
cmoinier
force-pushed
the
filter-by-category-ds-page
branch
3 times, most recently
from
88c0f4b to
2ceb016
Compare
cmoinier
force-pushed
the
filter-by-category-ds-page
branch
from
2ceb016 to
23e957a
Compare
Angi-Kinas
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Thanks @cmoinier for implementing this new filter!
I tested it locally and it works as expected.
Not sure if we should add a test here for the existence of this filter? WDYT?
Angi-Kinas
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds filtering when the user clicks on the category badges on the dataset page.
It also removes a duplicate style class.