feat(runtime): fail without retries on ConncectorInputException

camunda · Jan 13, 2025 · 081fea6 · 081fea6
1 parent 2fcec35
commit 081fea6
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/...me-core/src/main/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandler.java b/...me-core/src/main/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandler.java
@@ -19,6 +19,7 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import io.camunda.connector.api.error.ConnectorException;
+import io.camunda.connector.api.error.ConnectorInputException;
 import io.camunda.connector.api.error.ConnectorRetryException;
 import io.camunda.connector.api.outbound.OutboundConnectorFunction;
 import io.camunda.connector.api.secret.SecretProvider;
@@ -212,10 +213,15 @@ public void handle(final JobClient client, final ActivatedJob job) {
       LOGGER.debug(
           "Exception while processing job: {} for tenant: {}", job.getKey(), job.getTenantId(), ex);
       String errorCode = null;
+      int retries = job.getRetries() - 1;
       if (ex instanceof ConnectorException connectorException) {
         errorCode = connectorException.getErrorCode();
+        Throwable cause = connectorException.getCause();
+        if (cause instanceof ConnectorInputException) {
+          retries = 0;
+        }
       }
-      result = handleSDKException(job, ex, job.getRetries() - 1, errorCode, retryBackoff);
+      result = handleSDKException(job, ex, retries, errorCode, retryBackoff);
     }
 
     try {

diff --git a/...ore/src/test/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandlerTest.java b/...ore/src/test/java/io/camunda/connector/runtime/core/outbound/ConnectorJobHandlerTest.java
@@ -35,6 +35,7 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import io.camunda.connector.api.error.ConnectorException;
 import io.camunda.connector.api.error.ConnectorExceptionBuilder;
+import io.camunda.connector.api.error.ConnectorInputException;
 import io.camunda.connector.api.error.ConnectorRetryExceptionBuilder;
 import io.camunda.connector.api.outbound.OutboundConnectorFunction;
 import io.camunda.connector.runtime.core.ConnectorHelper;
@@ -507,6 +508,26 @@ void shouldTruncateBpmnErrorMessage() {
       assertThat(result.getErrorMessage().length())
           .isLessThanOrEqualTo(ConnectorJobHandler.MAX_ERROR_MESSAGE_LENGTH);
     }
+
+    @Test
+    void shouldNotRetry_OnConnectorInputException() {
+      // given
+      var jobHandler =
+          newConnectorJobHandler(
+              context -> {
+                throw new ConnectorExceptionBuilder()
+                    .message("expected Connector Input Exception")
+                    .cause(new ConnectorInputException(new Exception()))
+                    .build();
+              });
+
+      // when
+      var result = JobBuilder.create().withRetries(3).executeAndCaptureResult(jobHandler, false);
+
+      // then
+      assertThat(result.getErrorMessage()).isEqualTo("expected Connector Input Exception");
+      assertThat(result.getRetries()).isEqualTo(0);
+    }
   }
 
   @Nested
@@ -935,7 +956,7 @@ void shouldCreateBpmnError_UsingExceptionCodeAsFirstCondition() {
     }
 
     @Test
-    void shouldCreateJobErrpr_UsingExceptionCodeAsSecondConditionAfterResponseProperty()
+    void shouldCreateJobError_UsingExceptionCodeAsSecondConditionAfterResponseProperty()
         throws JsonProcessingException {
       // given
       var errorExpression =