feat: document handling #3361
Merged
feat: document handling #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip (cherry picked from commit a57e940) * wip (cherry picked from commit 5634aea) * prepare end-to-end draft (cherry picked from commit 92ec79f) * prepare end-to-end draft (cherry picked from commit 5a808bd) * rework deserializers (cherry picked from commit 0b0a558) * incorporate feedback, move jackson code into a separate module * clean up accidental change * naming adjustments * lint * remove extra dollar sign * remove extra dollar sign
…different package (#3149) * refactor: move document stuff to a different module --------- Co-authored-by: Jonathan Roques <[email protected]>
#2976) * feat(doc-handling): Some investigations to use documents in the REST connector
github-actions
bot
temporarily deployed
to
connectors-epic-1748-doc-r-c8sm
sbuettner
reviewed
Sep 26, 2024
| this( | ||
| secretProvider, | ||
| validationProvider, | ||
| new DocumentFactoryImpl(InMemoryDocumentStore.INSTANCE), |
There was a problem hiding this comment.
I think we should always expect this parameter to be passed in.
github-actions
bot
temporarily deployed
to
connectors-epic-1748-doc-r-c8sm
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return new CamundaDocument( | ||
| camundaDocumentReference.metadata(), camundaDocumentReference, documentStore); | ||
| } | ||
| if (reference instanceof ExternalDocumentReference ignored) { |
Check notice
Code scanning / CodeQL
Unread local variable Note
|
|
||
| boolean matches(DocumentOperation operationReference); | ||
|
|
||
| Object execute(DocumentOperation operationReference, Document document); |
Check notice
Code scanning / CodeQL
Useless parameter Note
github-actions
bot
temporarily deployed
to
connectors-epic-1748-doc-r-c8sm
github-actions
bot
temporarily deployed
to
connectors-epic-1748-doc-r-c8sm
chillleader
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add the document handling changes that have been previously accumulated in a separate branch.
Related issues
related: https://github.com/camunda/team-connectors/issues/873
Checklist
no milestonelabel.