Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): error messages are now delivered correctly to operate when input validation fails #3704

Closed
wants to merge 2 commits into from
Closed

fix(runtime): error messages are now delivered correctly to operate when input validation fails #3704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b259e6
fix(runtime): error messages are now delivered correctly to operate w…
mathias-vandaele Nov 25, 2024
41851b4
fix(runtime): code formatting
mathias-vandaele Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...idation/src/main/java/io/camunda/connector/validation/impl/DefaultValidationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ protected String composeMessage(Set<ConstraintViolation<Object>> violations) {
* property values.
*/
protected String buildValidationMessage(ConstraintViolation<Object> violation) {
return " - Property: " + violation.getPropertyPath().toString() + ": Validation failed.";
return " - Property: "
+ violation.getPropertyPath().toString()
+ ": Validation failed. Original message: "
+ violation.getMessage();
}
}
2 changes: 2 additions & 0 deletions ...s-textract/src/test/java/io/camunda/connector/textract/TextractConnectorFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/
package io.camunda.connector.textract;

import static io.camunda.connector.textract.model.TextractRequestData.WRONG_OUTPUT_VALUES_MSG;
import static io.camunda.connector.textract.util.TextractTestUtils.ASYNC_EXECUTION_JSON_WITH_ROLE_ARN_AND_WITHOUT_SNS_TOPIC;
import static io.camunda.connector.textract.util.TextractTestUtils.ASYNC_EXECUTION_JSON_WITH_SNS_TOPIC_AND_WITHOUT_ROLE_ARN;
import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -85,6 +86,7 @@ void executeAsyncReqWithS3PrefixAndWithoutS3Bucket() {
ConnectorInputException.class,
() -> textractConnectorFunction.execute(outBounderContext));

assertThat(exception).hasMessageContaining(WRONG_OUTPUT_VALUES_MSG);
assertThat(exception).isInstanceOf(ConnectorInputException.class);
}

Expand Down
Loading