Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use preferred formats for MappableConcept.mappings #215

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Dec 27, 2024

close #212

  • system will use OBO Foundry persistent URL (PURL), source homepage, or namespace prefix, in that order of preference, if available.
  • code will use the concept_id as the CURIE

close #212

* use preferred format (URI) for `system`, where possible
@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Dec 27, 2024
@korikuzma korikuzma self-assigned this Dec 27, 2024
@korikuzma
Copy link
Member Author

Ope, forgot to update schemas / check docs. One sec

jsstevenson
jsstevenson previously approved these changes Dec 27, 2024
@jsstevenson jsstevenson self-requested a review December 27, 2024 17:49
src/disease/schemas.py Outdated Show resolved Hide resolved
jsstevenson
jsstevenson previously approved these changes Dec 31, 2024
@jsstevenson jsstevenson requested review from jsstevenson and removed request for jsstevenson December 31, 2024 14:35
@korikuzma korikuzma marked this pull request as draft December 31, 2024 15:53
@korikuzma korikuzma marked this pull request as ready for review December 31, 2024 16:57
@korikuzma korikuzma merged commit 7ce49c1 into main Dec 31, 2024
24 checks passed
@korikuzma korikuzma deleted the issue-212 branch December 31, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use preferred formats for MappableConcept.mappings
2 participants