Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct P310 URI typo in NCIt extraction #219

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

jsstevenson
Copy link
Member

this looks like it had to have been a typo

@jsstevenson jsstevenson added the priority:low Low priority label Jan 6, 2025
@korikuzma
Copy link
Member

Does this mean disease + therapy ddb need to be updated again?

@jsstevenson
Copy link
Member Author

@korikuzma well

  1. depends on your definition of "need" and

  2. I can double-check whether this change has a meaningful effect on term creation before pulling it out of draft

@jsstevenson
Copy link
Member Author

jsstevenson commented Jan 6, 2025

@korikuzma none of these entities were included in normalized groups* (which makes sense, since the groups are defined by Mondo xrefs). There are some very niche changes that could happen from the /search endpoint but otherwise shouldn't matter, I wouldn't bother re-updating.

*I generated a diff of the concept_id column from before and after the PR, then ran raw queries on each resulting concept (there were about 500) to see if any of them had a value for merged_concept -- none did

@jsstevenson jsstevenson requested a review from korikuzma January 6, 2025 17:02
@jsstevenson jsstevenson changed the title fix: correct P310 URI typo fix: correct P310 URI typo in NCIt extraction Jan 6, 2025
@korikuzma
Copy link
Member

@jsstevenson Okay, that's great news. Thank you for looking into it!

@jsstevenson jsstevenson merged commit fcc59a1 into main Jan 6, 2025
25 checks passed
@jsstevenson jsstevenson deleted the ncit-typo branch January 6, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants