-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update /search/studies
endpoint
#279
Conversation
* Update database nodes and relationships * Dropped Variation Group. We can add back in new issue if we want to retain this * Update versions for disease-normalizer, civicpy, pydantic, and neo4j * Changed fixture scope in `tests/conftest.py` to `session`
* fix: typo in CODING_KEYS * change: study now has alleleOrigin property with HAS_GENE_CONTEXT rel
The last commit added support for providing genomic variation query. At the moment, only CIViC studies will be returned. Once #283 is complete, MOA assertions should also be returned |
Something is happening with the Using 20240103 |
* start can be 0, so needed to do null check
#310 fixes this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good
@jsstevenson applied your suggestions. I also don't love the ordering of methods. I can re-order after you review latest changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah seems reasonable
close #273 . I will open once #266 is merged
@jsstevenson again, fresh eyes would be helpful for this 😄
Notes:
/search/statements
endpoint. Will address Movevariant.definingContext.expressions
tovariant.members
#309 at a later time. This PR is to kind of mirror what was done previously, so I'd like to address "major" response changes in separate issues if possible.definingContext
or amembers
matchChanges:
/search/statements
to/search/studies
and updated to use the latest schema/search
and/search/{id}
which will be added in Update/search
endpoint for gk-pilot schemas #274 and Updatesearch/{id}
endpoint for gk-pilot schemas #272