Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: update normalizer + ga4gh.vrs depdencies #386

Merged
merged 1 commit into from
Jul 16, 2024
Merged

build!: update normalizer + ga4gh.vrs depdencies #386

merged 1 commit into from
Jul 16, 2024

Conversation

korikuzma
Copy link
Member

@korikuzma korikuzma commented Jul 16, 2024 •
edited
Loading

close #379

  • aliases renamed to alternativeLabels and type removed from Extension object in response.

@korikuzma korikuzma added priority:medium Medium priority build Changes that affect the build system or dependencies labels Jul 16, 2024
@korikuzma korikuzma requested a review from jsstevenson July 16, 2024 18:41
@korikuzma korikuzma self-assigned this Jul 16, 2024
@jsstevenson
Copy link
Member

also, fwiw, I am not sure you need to mark this as a breaking change (doesn't really matter though)

@korikuzma
Copy link
Member Author

also, fwiw, I am not sure you need to mark this as a breaking change (doesn't really matter though)

Oh, I thought since the output changed from alias to alternativeLabels as well as removing type from Extension field that it would be considered breaking

@korikuzma korikuzma merged commit 1563018 into staging Jul 16, 2024
17 checks passed
@korikuzma korikuzma deleted the issue-379 branch July 16, 2024 19:22
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
Closed
@jsstevenson jsstevenson mentioned this pull request Jan 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsstevenson jsstevenson jsstevenson approved these changes

Assignees

@korikuzma korikuzma

Labels
build Changes that affect the build system or dependencies priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @jsstevenson