Fix obsolete cockpit defer API

done/fail/always is the long-obsolete `cockpit.defer()` jQuery promise
API, which will be dropped eventually. Replace them with the standard
`Promise` API.

This requires a little teak in safeDBusCall() -- while `.fail()` also
returns the rejection, `Promise.catch()` handles it and returns nothing.

In `InstalledProducts.handleAutoAttach()`, both handlers in were doing
exactly the same thing, so use finally() instead. Also use an arrow
instead of a function to avoid the `self = this` dance.

src/subscriptions-client.js

@@ -136,18 +136,19 @@ function parseErrorSeverity(error) {
  * Method that calls a method on a dbus service proxy, only if it is available.
  *
  * If the service does not contain the provided method, we try to restart the rhsm service,
- * and if the restart is successful, we call the delegate method; otherwise, we fail gracefully.
+ * and if the restart is successful, we call the delegate method; otherwise, log the error
+ * and return a Promise rejection.
  *
  * @param serviceProxy a dbus service proxy
  * @param methodName a method on the provided serviceProxy
  * @param delegateMethod the method that we delegate the actual call to dbus
  */
 function safeDBusCall(serviceProxy, delegateMethod) {
-    return serviceProxy.wait()
-            .then(delegateMethod)
-            .fail(ex => {
-                console.debug(ex);
-            });
+    const promise = serviceProxy.wait()
+            .then(delegateMethod);
+    // we do want the caller to receive the rejection, so don't handle it
+    promise.catch(console.debug);
+    return promise;
 }
 
 let gettingDetails = false;
@@ -435,9 +436,9 @@ client.registerSystem = (subscriptionDetails, update_progress) => new Promise((r
                     client.closeRegisterDialog = true;
                     isRegistering = false;
                     console.debug('requesting update of subscription status');
-                    requestSubscriptionStatusUpdate().always(resolve)
+                    requestSubscriptionStatusUpdate().finally(resolve)
                     console.debug('requesting update of syspurpose status');
-                    requestSyspurposeStatusUpdate().always(resolve)
+                    requestSyspurposeStatusUpdate().finally(resolve)
                 });
     });
 });
@@ -455,7 +456,7 @@ client.unregisterSystem = () => {
                         'msg': parseErrorMessage(error)
                     };
                 })
-                .always(() => {
+                .finally(() => {
                     console.debug('requesting update');
                     requestSubscriptionStatusUpdate();
                 });

src/subscriptions-view.jsx

@@ -49,24 +49,17 @@ class InstalledProducts extends React.Component {
         if (!event || event.button !== 0)
             return;
         if (this.props.autoAttach) {
-            let self = this;
             this.setState({
                 attaching_in_progress: true,
                 attach_button_text: _("Auto-attaching ...")
             });
             this.props.autoAttach()
-                    .done(function () {
-                        self.setState({
+                    .finally(() =>
+                        this.setState({
                             attaching_in_progress: false,
                             attach_button_text: _("Auto-attach")
-                        });
-                    })
-                    .fail(function () {
-                        self.setState({
-                            attaching_in_progress: false,
-                            attach_button_text: _("Auto-attach")
-                        });
-                    });
+                        })
+                    );
         }
     }