-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration tests for DBus Unregister call #3484
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix failed test. Suggestion is in the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, squash commits 1, 3, 4 and add appropriate commit messages. Thanks
@@ -42,7 +42,6 @@ EOF | |||
./integration-tests/scripts/run-local-candlepin.sh | |||
|
|||
# create testing data in local candlepin | |||
./integration-tests/scripts/post-activation-keys.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against of removing this line as a part of this PR, but please add some meaningful commit message to related commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok next time I will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be part of different commit or please remove this change from this PR.
323a6e6
to
d477a54
Compare
After I re-run a check 'tmt @ fedora41' the check finished with PASSED. It must be a temporary problem of tmt stack rather than an error in testing stack. I will keep observing this check to get deeper into this problem. |
Card-ID: CCT-738
integration tests for DBus Unregister call
there are two tests in the PR