fix: Restart rhsm service after installation #3485
Conversation
|
I am not sure about the failing test 😿. However, here is a setup how you can test this change:
#!/bin/bash
source ./library.sh
start_register_server
export username="admin"
export password="admin"
export org_id="content-sources-test"
echo "Trying to get list of organizations using dbus-send..."
dbus-send --address=${my_addr} --print-reply --dest='com.redhat.RHSM1.Register' \
'/com/redhat/RHSM1/Register' \
com.redhat.RHSM1.Register.GetEnvironments string:${username} \
string:${password} \
string:${org_id} \
dict:string:string:"","" \
string:""
stop_register_server |
subscription-manager.spec
Outdated
| %systemd_post rhsm.service | ||
| systemctl restart rhsm.service |
There was a problem hiding this comment.
Reference of the RPM macros: https://github.com/systemd/systemd/blob/46f881e32127cce03118dcd0471ded12d08d50b2/src/rpm/macros.systemd.in
%systemd_post in practice only installs the new service, and it does not do anything more than that
What seems to be needed here is %systemd_postun_with_restart, which seems to be marking the unit as "needs to be restarted", and then the rpm file triggers will make systemd restart the units marked as "no be restarted". Please note that the right place for that is in %postun, not %post.
* Card ID: CCT-1027 Following the installation of the subscription-manager package, the dbus service was not loaded as expected. This update addresses the problem by ensuring that the dbus service is properly restarted after the installation or upgrade process.
There was a problem hiding this comment.
Thanks for the update!
The new macro does the trick, however only when the package with the scriptlet is removed, either because of uninstallation or upgrade. This means that when upgrading from a sub-man without this change to a sub-man with this change rhsm.service will not be restarted, since only the %preun of the already installed sub-man (i.e. that one without this change) is run.
As references to the RPM scriptlets, in particular the sections for syntax and ordering:
- https://docs.pagure.org/packaging-guidelines/Packaging%3AScriptlets.html
- https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
What I think we need here is to do the restart in %posttrans; according to the RPM macros for systemd (see the link I mentioned in my previous comment), %systemd_posttrans_with_restart should do it, and that needs to be placed in the %posttrans section.
The C10S job was fixed after #3495, so make sure to rebase. |
Following the installation of the subscription-manager package, the dbus service was not loaded as expected. This update addresses the problem by ensuring that the dbus service is properly restarted after the installation or upgrade process.