fix: Really disable content #3500
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage (computed on Fedora latest) •
|
||||||||||||||||||||||||||||||
jirihnidek
force-pushed
the
jhnidek/really_disable_content
branch
2 times, most recently
from
6a3f82d to
ab9a29e
Compare
jirihnidek
force-pushed
the
jhnidek/really_disable_content
branch
from
ab9a29e to
dfcb41f
Compare
* CCT-1005 * When D-Bus method Register() or RegisterWithActivationKeys() is called with "enable_content": false, rhsm.service will not download and install SCA cerificate, but it is not enough, because later rhsmcertd or "subscription-manager status" will download SCA certificate and it will generated redhat.repo file * For this reason, when "enable_content" is false, then manage_repos will be set to 0 to be sure that redhat.repo will not be generated later * Fixed unit tests * TODO: Do not download SCA certificate, when manage_repos is equal to "0", because it is useless activity and it consumes resources on candlepin server
jirihnidek
force-pushed
the
jhnidek/really_disable_content
branch
from
dfcb41f to
2d99bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
called with "enable_content": false, rhsm.service will not
download and install SCA cerificate, but it is not enough,
because later rhsmcertd or "subscription-manager status"
will download SCA certificate and it will generated redhat.repo
file
manage_repos will be set to 0 to be sure that redhat.repo
will not be generated later
equal to "0", because it is useless activity and it
consumes resources on candlepin server