Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confdb,asserts,daemon: add confdb-control api #14866

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

st3v3nmw
Copy link
Contributor

@st3v3nmw st3v3nmw commented Dec 17, 2024

This PR introduces the confdb-control API to snapd.

Please do not review just yet. Awaiting:

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Dec 17, 2024
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from 1e10d53 to 983bc9d Compare December 17, 2024 10:09
@st3v3nmw st3v3nmw changed the title confdb, daemon: add confdb-control api confdb,daemon: add confdb-control api Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 98.99666% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (24a0034) to head (8ccd304).
Report is 112 commits behind head on master.

Files with missing lines Patch % Lines
daemon/api_confdb.go 95.58% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14866      +/-   ##
==========================================
+ Coverage   78.20%   78.29%   +0.09%     
==========================================
  Files        1151     1157       +6     
  Lines      151396   153696    +2300     
==========================================
+ Hits       118402   120343    +1941     
- Misses      25662    25947     +285     
- Partials     7332     7406      +74     
Flag Coverage Δ
unittests 78.29% <98.99%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from 983bc9d to ea1a5cf Compare December 18, 2024 12:53
@st3v3nmw st3v3nmw changed the title confdb,daemon: add confdb-control api confdb,asserts,daemon: add confdb-control api Dec 18, 2024
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch 3 times, most recently from 4544d41 to 1ed5ca7 Compare December 20, 2024 11:19
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch 11 times, most recently from 8205f5a to 557bd56 Compare January 9, 2025 12:26
@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch 2 times, most recently from 4dadbcf to a6ffff9 Compare January 14, 2025 10:26
Copy link

github-actions bot commented Jan 14, 2025

Thu Jan 16 15:42:52 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/12809839545

Failures:

Preparing:

  • openstack:debian-12-64:tests/regression/lp-2084730
  • openstack:opensuse-15.6-64
  • openstack:opensuse-tumbleweed-64:tests/main/snapshot-users

Executing:

  • openstack:debian-12-64:tests/main/appstream-id
  • openstack:debian-sid-64:tests/main/refresh-amend:try_mode
  • google-distro-1:debian-11-64:tests/main/confdb
  • google:ubuntu-25.04-64:tests/main/lxd-try

Restoring:

  • openstack:debian-12-64:tests/regression/lp-2084730
  • openstack:opensuse-15.6-64

@st3v3nmw st3v3nmw force-pushed the add-confdb-control-api branch from a6ffff9 to 8ccd304 Compare January 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant