Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i/b/fwupd: allow access to dell bios recovery #14920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

i/b/fwupd: allow access to dell bios recovery #14920

wants to merge 1 commit into from

Conversation

CragW
Copy link

@CragW CragW commented Jan 13, 2025

Fixes: Upstream issue: fwupd/fwupd#8227

bboozzoo
bboozzoo approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboozzoo bboozzoo added the Needs security review Can only be merged once security gave a :+1: label Jan 13, 2025
@bboozzoo bboozzoo assigned alexmurray and zyga and unassigned alexmurray and zyga Jan 13, 2025
@bboozzoo bboozzoo requested review from alexmurray and zyga January 13, 2025 10:14
@bboozzoo bboozzoo self-assigned this Jan 13, 2025
alexmurray
alexmurray approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@alexmurray alexmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmurray alexmurray removed the Needs security review Can only be merged once security gave a :+1: label Jan 13, 2025
@bboozzoo
Copy link
Contributor

@CragW can you rebase on top of master and force push?

@CragW
Copy link
Author

CragW commented Jan 16, 2025

@CragW can you rebase on top of master and force push?

Sure, updated to the latest. Thanks.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Fri Jan 17 16:23:48 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/12813050979

Failures:

Preparing:

  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64

Executing:

  • openstack:opensuse-15.6-64:tests/main/snap-set-core-w-no-core

Restoring:

  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64:tests/main/appstream-id
  • openstack:opensuse-15.6-64:tests/main/
  • openstack:opensuse-15.6-64

@bboozzoo bboozzoo added this to the 2.68 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyga zyga zyga approved these changes

@alexmurray alexmurray alexmurray approved these changes

@bboozzoo bboozzoo bboozzoo approved these changes

Assignees

@bboozzoo bboozzoo

Labels
None yet
Projects
None yet
Milestone
2.68
Development

Successfully merging this pull request may close these issues.
4 participants
@CragW @bboozzoo @alexmurray @zyga