interfaces,dirs: add ldconfig backend #14926
Conversation
alfonsosanchezbeato
requested review from
bboozzoo,
pedronis and
Meulengracht
|
Tue Jan 14 19:56:29 UTC 2025 Failures:Prepare:
Restoring:
|
dirs/dirs.go
Outdated
| @@ -465,6 +466,7 @@ func SetRootDir(rootdir string) { | |||
|
|
|||
| SnapDataDir = filepath.Join(rootdir, "/var/snap") | |||
| SnapAppArmorDir = filepath.Join(rootdir, snappyDir, "apparmor", "profiles") | |||
| SnapLdconfigDir = filepath.Join(rootdir, "etc/ld.so.conf.d") | |||
There was a problem hiding this comment.
nitpick: the style here seems to be /etc...
interfaces/ldconfig/backend.go
Outdated
| // the rootfs. For snaps, we will create files in | ||
| // /var/lib/snapd/ldconfig/ that will be used to generate a cache | ||
| // specific to each snap. | ||
| ldconfigPath := filepath.Join(dir, "snapd.conf") |
There was a problem hiding this comment.
I'm confused, specification are per snap app set but here we reuse the same file? won't multiple snap stomp on each ther?
There was a problem hiding this comment.
I have changed this. However I started to re-think about this and I am not sure anymore, maybe I'm missing some piece. I created snapd.conf thinking of it as the only config file for the "system" (rootfs) snap (the implementation is not considering exporting libraries to snap yet). That is, the "snap app set" here is the rootfs. Afaiu any change in interfaces would trigger the call to Setup(), and having multiple files will help with knowing where libraries come from (this could still be done by adding comments in snapd.conf), but there is no other practical effect as the call to ldconfig will process all files in here.
My plan for the implementation for the snaps case, is to have also only one config file per snap, that will be seen in ld.so.conf.d/ but only for the mount namespace of the snap, that would be a mix of the contents of the app base and of these files generated by snapd (that will be found also in the rootfs in, maybe, /var/lib/snapd/ldconfig/).
This backend will expose libraries coming from snaps to either the rootfs or to other snaps (currently supporting only the former).
alfonsosanchezbeato
force-pushed
the
ldconfig-backend
branch
from
df1088b to
c5cad2c
Compare
This backend will expose libraries coming from snaps to either the
rootfs or to other snaps (currently supporting only the former).