image: added feature to inject proxy store assertions in build image #14947
+186
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image: added feature to inject proxy store assertions in build image
This PR adds the possibility of including extra assertions in the created image at build time.
The reason for this is avoiding workarounds such as stopping the build, including proxy store assertions and resuming the build.
The solution adds the necessary fields to
image.Optionsand the necessary control flow so that assertions contained in files passed with the--assertoption (and in the future in the calls fromubuntu-image) will be imported and saved to the seed.For now, only store assertions are allowed as I couldn't see a way to have a truly polymorphic approach to decoding each kind of assertion, resulting in the code found here. With this structure, making a new kind of assertion injectable would require adding its type to the 'switch`.