fix: nested ternary in calculated element #981
Merged
+48
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calculated elements may reference other calcuated elements and so forth.. that is why we have logic in place which constructs subpaths for such scenarios which enables us to calculate joins deeply built into a given calculated element hierarchy. However, the logic had a flaw for e.g. nested ternary expressions. For `(1 > 0 ? 1 : (book.stock > 10 ? value : 3));` we accidentally constructed subpaths like `book.stock.value` which led to an error because we tried to create a join for `value`, where no association prefix is present. fix cap/issue#17660
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
sjvans and
David-Kunz
as code owners
stewsk
approved these changes
Jan 17, 2025
|
@patricebender can you please checks whether this works in the compiler? |
I did and it doesn't work. Gute Nase! Opened an internal issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculated elements may reference other calcuated elements and so forth.. that is why we have logic in place which constructs subpaths for such scenarios which enables us to calculate joins deeply built into a given calculated element hierarchy. However, the logic had a flaw for e.g. nested ternary expressions.
For
(1 > 0 ? 1 : (book.stock > 10 ? value : 3));we accidentally constructed subpaths like
book.stock.valuewhich led to an error because we tried to create a join forvalue, where no association prefix is present.fix cap/issue#17660