Adjusted to support multitenancy #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkaputnik
reviewed
Dec 23, 2024
| }); | ||
| } else { | ||
| keys.push(e); | ||
| if (!entity['@changelog.disable_assoc']) { // REVISIT: why do we need that annotation? |
There was a problem hiding this comment.
This is a flag to disable automatic association definition. This is for people who want to change-track things, but don't want the change-log to be attached to the entity itself. They rather build a central Admin UI to view all changes.
One of the reasons is also, that ALL changes are visible through this association, regardless of who did them, something some stakeholders see as security issue
nkaputnik
reviewed
Dec 23, 2024
| if(!entity['@changelog.disable_facet']) | ||
| entity['@UI.Facets']?.push(facet) | ||
| // Add UI.Facet for Change History List | ||
| if (!entity['@changelog.disable_facet']) // REVISIT: why do we need that annotation? |
There was a problem hiding this comment.
As above, this was actually the most requested feature from the users...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.