Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Facet with annotation #86

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

pandayo
Copy link
Contributor

@pandayo pandayo commented Apr 19, 2024

Hello everyone,

with this patch I suggest adding the annotation @changelog.disable_facet to disable the facet on an entity completely.
This might be useful if we have deep fiori UIs where a lot of the entities are tracked. Depending on the configuration, I want all of them tracked on the main entity, yet empty facets are shown on the subpages anyway.

Have a nice weekend and feel free to ask questions.

Kind regards

pandayo and others added 3 commits April 19, 2024 14:10
Enable the possibility to disable the change-tracking ui facet by annotating the entity using @changelog.disable_facet. This can be wanted because changes are by default tracked on the upmost draft enabled entity and the facet will be shown on deeper levels anyway.
@nkaputnik nkaputnik self-requested a review April 25, 2024 07:51
@nkaputnik
Copy link
Contributor

Hello @pandayo , thank you a lot for you contribution!
I have approved and merged this feature and it will be part of the next release

@nkaputnik nkaputnik merged commit 877579c into cap-js:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants