Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft of documenting feature flags #518

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

johannes-vogel
Copy link
Contributor

No description provided.

@johannes-vogel
Copy link
Contributor Author

@David-Kunz @sjvans Do you know any additional feature flag that must be documented?

@sjvans
Copy link
Contributor

sjvans commented Nov 21, 2023

@David-Kunz @sjvans Do you know any additional feature flag that must be documented?

did you check cds/lib/env/defaults.js?

maybe:

  • precompile_edms
  • serve_on_root
  • skip_unused
  • implicit_next (or rather remove?!)
  • keys_in_data_compat
  • okra_skip_query_options
  • precise_timestamps
  • optimized_search

kibana_formatter can probably be left out as i'm already working on removing it...

@johannes-vogel
Copy link
Contributor Author

  • precompile_edms → obsolete with okra replacement? If yes, don't document.
  • serve_on_root → should include for now
  • skip_unused → It's not documented, I'd skip that for now.
  • implicit_next (or rather remove?!) → remove, compat from cds 4
  • keys_in_data_compat → rather remove, compat from cds 5
  • okra_skip_query_options → I'd not document that because of okra replacement
  • precise_timestamps → intentionally undocumented for now
  • optimized_search → probably should document
  • kibana_formatter → remove

@arleytm
Copy link
Contributor

arleytm commented Feb 7, 2024

@johannes-vogel

  • stream_compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants